Fix small xtrigger housekeeping bug. - #7026
Merged
Merged
Conversation
hjoliver
force-pushed
the
xtrigger-housekeeping-fix
branch
from
October 10, 2025 00:20
a1b45b6 to
3953fce
Compare
hjoliver
commented
Oct 10, 2025
| # General case: potentially slow asynchronous function call. | ||
| if sig in self.sat_xtrig: | ||
| # Already satisfied, just update the task | ||
| LOG.info(f"[{itask}] satisfying xtrigger prerequisite: {sig}") |
Member
Author
There was a problem hiding this comment.
IMO we should log this as INFO, as confirmation that an xtrigger prerequisite is being satisfied by an existing xtrigger result.
hjoliver
force-pushed
the
xtrigger-housekeeping-fix
branch
from
October 10, 2025 00:30
3953fce to
b8ba58a
Compare
hjoliver
commented
Oct 10, 2025
| LOG.debug(f"Housekeeping xtrigger result: {sig}") | ||
| del self.sat_xtrig[sig] | ||
| with suppress(KeyError): | ||
| del self.t_next_call[sig] |
wxtim
approved these changes
Nov 6, 2025
dwsutherland
approved these changes
Nov 27, 2025
Member
|
Might need to be raised against 8.6.x |
oliver-sanders
force-pushed
the
xtrigger-housekeeping-fix
branch
from
November 27, 2025 09:53
c57c166 to
7add1ad
Compare
Member
|
Changed base branch to 8.6.1 and rebased onto 8.6.x (was based on master). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while investigating this forum post
The "next call" dict in
xtrigger_mgris not being housekept, so if the same xtrigger comes back into the pool later the "commencing xtrigger call" message will not be logged again when the calls do re-commence.Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.